Re: [PATCH v2 1/3] x86/bugs: Only harden syscalls when needed

[Josh Poimboeuf]

On Fri, Apr 12, 2024 at 03:42:32PM -0700, Pawan Gupta wrote:
> On Fri, Apr 12, 2024 at 11:10:32AM -0700, Josh Poimboeuf wrote:
> > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
> > index 3c7434329661..7c87fe80c696 100644
> > --- a/arch/x86/include/asm/cpufeatures.h
> > +++ b/arch/x86/include/asm/cpufeatures.h
> > @@ -470,6 +470,7 @@
> >  #define X86_FEATURE_BHI_CTRL		(21*32+ 2) /* "" BHI_DIS_S HW control available */
> >  #define X86_FEATURE_CLEAR_BHB_HW	(21*32+ 3) /* "" BHI_DIS_S HW control enabled */
> >  #define X86_FEATURE_CLEAR_BHB_LOOP_ON_VMEXIT (21*32+ 4) /* "" Clear branch history at vmexit using SW loop */
> > +#define X86_FEATURE_INDIRECT_SAFE	(21*32+ 4) /* "" Indirect branches aren't vulnerable to Spectre v2 */
> 
> This should be (21*32+ 5).

Argh :-/

> Other than that:
> 
> Reviewed-by: Pawan Gupta <pawan.kumar.gupta@xxxxxxxxxxxxxxx>

Thanks!

-- 
Josh