Re: [PATCH RFC v2 5/6] blk-throttle: support to destroy throtl_data when blk-throttle is disabled

[Yu Kuai]

Hi,

在 2024/04/13 2:05, Tejun Heo 写道:
> Hello,
>
> On Sat, Apr 06, 2024 at 04:00:58PM +0800, Yu Kuai wrote:
> > From: Yu Kuai <yukuai3@xxxxxxxxxx>
> >
> > Currently once blk-throttle is enabled, it can't be destroyed until disk
> > removal, even it's disabled.
> >
> > Also prepare to support building it as kernel module.
>
> The benefit of doing this whenever the ruleset becomes empty seems marginal.
> This isn't necessary to allow unloading blk-throttle and
> blkg_conf_exit_blkg() is also necessary because of this, right?

Yes, this is why blkg_conf_exit_blkg() is necessary.

I think that we need find an appropriate time to unload blk-throttle
other than deleting the gendisk. I also think of adding a new user input
like "8:0 free" to do this. These are the solutions that I can think of
for now.

Thanks,
Kuai

> Thanks.