Re: [PATCH 4.19 000/175] 4.19.312-rc1 review

From: Greg Kroah-Hartman
Date: Sat Apr 13 2024 - 01:43:17 EST


On Fri, Apr 12, 2024 at 10:02:47PM +0200, Thomas Gleixner wrote:
> On Fri, Apr 12 2024 at 21:46, Pavel Machek wrote:
> >> Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> >> timers: Move clearing of base::timer_running under base:: Lock
> >
> > AFAICT, we don't have those NULL assignments in expire_timers in
> > 4.19. Can someone doublecheck this? We also don't support PREEMPT_RT
> > there.
>
> This has nothing to do with RT.
>
> But yes, 4.19 has the original bass::running_timer clearing which
> happens at the end of handling all expired timer callbacks and that
> actually happens with base->lock held.
>
> So right, 4.19 is not affected by this.

Now dropped, thanks.

greg k-h