Re: [PATCH 1/2] arm64: dts: rockchip: Add ArmSom Sige7 board

[Krzysztof Kozlowski]

On 13/04/2024 05:23, Jianfeng Liu wrote:
> Specification:
>         Rockchip Rk3588 SoC
>         4x ARM Cortex-A76, 4x ARM Cortex-A55
>         8/16/32GB Memory LPDDR4/LPDDR4x
>         Mali G610MP4 GPU
>         2× MIPI-CSI Connector
>         1× MIPI-DSI Connector
>         1x M.2 Key M (PCIe 3.0 4-lanes)
>         2x RTL8125 2.5G Ethernet
>         Onboard AP6275P for WIFI6/BT5
>         32GB/64GB/128GB eMMC
>         MicroSD card slot
>         1x USB2.0, 1x USB3.0 Type-A, 1x US3.0 Type-C
>         1x HDMI Output, 1x type-C DP Output
> 
> Functions work normally:
>         USB2.0 Host
>         USB3.0 Type-A Host (depend on just applied USBDP driver[1])
>         M.2 Key M (PCIe 3.0 4-lanes)
>         2x RTL8125 2.5G Ethernet
>         eMMC
>         MicroSD card
> 
> More information can be obtained from the following website
>         https://docs.armsom.org/armsom-sige7
> 
> [1] https://lore.kernel.org/all/20240408225109.128953-1-sebastian.reichel@xxxxxxxxxxxxx/
> 
> Signed-off-by: Jianfeng Liu <liujianfeng1994@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588-armsom-sige7.dts | 725 ++++++++++++++++++
>  2 files changed, 726 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 7da198be8..0624c7284 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -111,6 +111,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-roc-pc.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-coolpi-cm5-evb.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtbo
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts b/arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts
> new file mode 100644
> index 000000000..aa45e60bb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts
> @@ -0,0 +1,725 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> +#include "rk3588.dtsi"
> +
> +/ {
> +	model = "ArmSoM Sige7";
> +	compatible = "armsom,sige7", "rockchip,rk3588";

Bindings come before users.

> +
> +	aliases {
> +		mmc0 = &sdhci;
> +		mmc1 = &sdmmc;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial2:1500000n8";
> +	};
> +
> +	analog-sound {
> +		compatible = "audio-graph-card";
> +		label = "rk3588-es8316";
> +
> +		widgets = "Microphone", "Mic Jack",
> +			  "Headphone", "Headphones";
> +
> +		routing = "MIC2", "Mic Jack",
> +			  "Headphones", "HPOL",
> +			  "Headphones", "HPOR";
> +
> +		dais = <&i2s0_8ch_p0>;
> +		hp-det-gpio = <&gpio1 RK_PD5 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&hp_detect>;
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&led_rgb_g>;
> +
> +		led_rgb_g {

No underscores in node names.

Best regards,
Krzysztof