Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts

From: Dragan Simic
Date: Sat Apr 13 2024 - 04:07:51 EST


Hello Wolfram,

On 2024-04-13 09:10, Wolfram Sang wrote:
Hi Dragan,

Sure, but I think that having such an additional debug facility
can only help and save the people from adding temporary printk()s
while debugging.

Mileages, I guess. I like temporary printouts for temporary debug
sessions. This way the upstream source code stays slim. In my experience
with I2C over the years, debugging happens with developers anyhow.
Logfiles from users which help developers create patches are very rare.
And those users are usually capable enough to add debug patches.
Given these experiences (which may be different in other subsystems), I
don't see why we should carry the bloat.

Yup, adding some printk()s while debugging is pretty much inevitable,
and having full debugging available would add a lot of code, regardless
of the subsystem.

That said, I'll leave the final decision to the driver maintainers.

Agreed.