Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding

[Krzysztof Kozlowski]

On 13/04/2024 12:51, Lukas Wunner wrote:
> On Sat, Apr 13, 2024 at 12:43:38PM +0200, Krzysztof Kozlowski wrote:
>> On 13/04/2024 12:34, Lukas Wunner wrote:
>>> The other patch just adds an entry to of_tis_i2c_match[] in the driver,
>>> pretty unspectacular:
>>>
>>> https://lore.kernel.org/all/20240413071621.12509-2-michael.haener@xxxxxxxxxxx/
>>
>> Then why is it needed?
> 
> The binding requires two entries in the compatible string used in the DT,
> the chip name followed by the generic string:
> 
>         items:
>           - enum:
>               - infineon,slb9673
>               - nuvoton,npct75x
>           - const: tcg,tpm-tis-i2c
> 
> This allows us to deal with device-specific quirks, should they pop up
> (e.g. special timing requirements, hardware bugs).  We don't know in
> advance if they will be discovered, but if they are, it's cumbersome
> to determine after the fact which products (and thus DTs) are affected.
> So having the name of the actual chip used on the board has value.

So you say devices are compatible. Then the second patch is wrong.

I cannot respond to it, though... so NAK-here-for-second-patch.

Best regards,
Krzysztof