Re: [PATCH v3 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document
From: Krzysztof Kozlowski
Date: Sat Apr 13 2024 - 17:44:59 EST
On 10/04/2024 11:29, Alexandre Mergnat wrote:
>
>
> On 09/04/2024 17:46, Krzysztof Kozlowski wrote:
>>> + soc {
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> +
>>> + afe@11220000 {
>> Did you implement the comment or decided to keep afe?
>>
>
> Though it was clear according to [1]:
> "
> Audio Front End, this is the same name used for other MTK SoC, to be
> consistent.
>
> Cook a new patch serie to change "afe" by "audio-controller" for all MTK
> SoC would be great.
> "
>
> I want to keep it and fix it later with ALL other MTK SoC.
> You didn't answer after that, I though it was ok for you...
Then no, I don't agree. If you add code, which you already plan to fix,
it means the code is not correct somehow. Then just add correct code in
the beginning.
Best regards,
Krzysztof