Re: [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents.

[Dan Carpenter]

The subject is too vague.

On Sun, Apr 14, 2024 at 05:21:06PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
  ^^^^^^^^^^^^^^^^^^^^^^^^^
What issue?

A better commit message would be:

==================
Subject: [PATCH v3] staging: vc04_services: re-align function parameters

Checkpatch complains that:

CHECK: Lines should not end with a '('
#45: FILE: drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h:45:
+typedef void (*vchiq_mmal_buffer_cb)(

Re-align the function parameters to make checkpatch happy.
================

> 
> Signed-off-by: sumadhura kalyan <opensourcecond@xxxxxxxxx>
                 ^         ^
You should make these capital letters...  It's supposed to look formal
like you're signing a legal document.

regards,
dan carpenter