Re: [PATCH net-next v10 08/13] ptp: Add phc source and helpers to register specific PTP clock or get information

[Willem de Bruijn]

Kory Maincent wrote:
> On Wed, 10 Apr 2024 23:00:53 -0400
> Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx> wrote:
> 
> > > +/**
> > > + * netdev_ptp_clock_register() - register a PTP hardware clock driver for
> > > + *				 a net device
> > > + *
> > > + * @info: Structure describing the new clock.
> > > + * @dev:  Pointer of the net device
> > > + */
> > > +
> > > +extern struct ptp_clock *
> > > +netdev_ptp_clock_register(struct ptp_clock_info *info,
> > > +			  struct net_device *dev);  
> > 
> > No need for explicit extern?
> 
> Indeed I don't think it is needed.
> I am wondering why few other functions uses it (ptp_clock_register,
> ptp_clock_event, ptp_clock_index). Do you know?

Perhaps it predates the coding style rule

    Do not use the ``extern`` keyword with function declarations as this makes
    lines longer and isn't strictly necessary.