Re: [PATCH v3 0/3] clk: samsung: introduce nMUX to reparent MUX clocks

[Tudor Ambarus]

On 4/13/24 09:47, Krzysztof Kozlowski wrote:
> On 28/03/2024 13:34, Tudor Ambarus wrote:
>> v3:
>> - update first patch:
>>   - remove __nMUX() as it duplicated __MUX() with an exception on flags.
>>   - update commit message
>>   - update comment and say that nMUX() shall be used where MUX reparenting
>>     on clock rate chage is allowed
>> - collect R-b, A-b tags
>>
> 
> Sorry for late response, somehow this end up deep in inbox. You

no worries!

> reference some non existing commits, so I think you do not work on
> mainline trees.

Ah, the horror, you're right, I messed up the fixes reference in commit
2. It's because I started working on this before that patch got
integrated. Would be good to extend checkpatch to catch such situations.

> 
> Also Fixes must come before other patches, so probably first patch
> should be squashed with second. Otherwise second patch is not a complete
> fix.

I don't mind squashing them. I noticed a tag that might help in this
situations: "Depends-on:". But I guess we can't use that in the same
patch set as when the maintainer applies the dependency and adds its
S-o-b tag, it will modify the sha1 of the commit. Will squash them.

Cheers,
ta