Re: [PATCH] sdhci: Fix SD card detection issue

From: Russell King (Oracle)
Date: Mon Apr 15 2024 - 03:22:42 EST


On Mon, Apr 15, 2024 at 10:18:39AM +0300, Adrian Hunter wrote:
> On 15/04/24 10:06, Richard Clark wrote:
> > The mmc_gpio_get_cd(...) will return 0 called from sdhci_get_cd(...), which means
> > the card is not present. Actually, the card detection pin is active low by default
> > according to the SDHCI psec, thus the card detection result is not correct, more
>
> SDHCI spec covers the SDHCI lines. GPIO is separate.

.. and the key bit of information that should be mentioned is in the
case of a GPIO, the GPIO library can be told if a GPIO is active-high
or active-low in either firmware or via the GPIO lookup data, and this
should be used instead of drivers inventing their own "quirking".

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!