Re: [PATCH v5 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support

[Alisa-Dariana Roman]

On 14.04.2024 00:19, Krzysztof Kozlowski wrote:
> On 13/04/2024 17:11, Alisa-Dariana Roman wrote:
> > Unlike the other AD719Xs, AD7194 has configurable differential
> > channels. The user can dynamically configure them in the devicetree.
> >
> > Also add an example for AD7194 devicetree.
> >
> > Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
> > ---
> >   .../bindings/iio/adc/adi,ad7192.yaml          | 74 +++++++++++++++++++
> >   1 file changed, 74 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> > index ba506af3b73e..855f0a2d7d75 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml

..

> > +  "^channel@[0-9]+$":
>
> Why restricting the pattern? If you have 256 channels, how are you going
> to encode it?

Hi Krzysztof,

Thank you for your feedback! I applied the rest, but as for this one 
isn't channel@1 -> channel@256 encoding sufficient?

Kind regards,
Alisa-Dariana Roman