Re: [PATCH v5 5/5] iio: adc: ad7192: Add AD7194 support

From: Andy Shevchenko
Date: Mon Apr 15 2024 - 09:40:20 EST


On Sat, Apr 13, 2024 at 11:05 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> On Sat, Apr 13, 2024 at 10:13 AM Alisa-Dariana Roman
> <alisadariana@xxxxxxxxx> wrote:

..

> > +static int ad7192_parse_channels(struct iio_dev *indio_dev)
>
> Better name might be ad7194_parse_channels() or
> ad7192_parse_ad7194_channels() since this is specific to the ad7194
> chip.

Quite unlikely we have the same chip to be supported by somewhere
else, so I would just name it simpler, i.e.

ad7194_parse_channels()

--
With Best Regards,
Andy Shevchenko