Re: [PATCH RFC net-next 5/7] netdev_features: convert NETIF_F_HIGHDMA to priv_flag IFF_HIGHDMA

[Simon Horman]

On Fri, Apr 05, 2024 at 03:37:29PM +0200, Alexander Lobakin wrote:
> The ability to send bufferst from the high memory is rather an
> attribute, not a feature. It can't be toggled via Ethtool and
> is constant for the whole interface lifetime.
> Convert it to a private flag, carrying necessary inheritance for
> lower interfaces.
> 
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

..

> index f57c29de3a91..78e749f6b91f 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -3007,6 +3007,7 @@ struct ieee80211_hw {
>  		s16 accuracy;
>  	} radiotap_timestamp;
>  	netdev_features_t netdev_features;
> +	u64 netdev_priv_flags;
>  	u8 uapsd_queues;
>  	u8 uapsd_max_sp_len;
>  	u8 max_nan_de_entries;

nit: please add netdev_features to the kernel-doc for struct ieee80211_hw.

Flagged by ./scripts/kernel-doc -none

..