Re: [PATCH v3 2/2] power: supply: ltc3350-charger: Add driver

From: Nícolas F. R. A. Prado
Date: Mon Apr 15 2024 - 11:34:42 EST


On Sun, Apr 14, 2024 at 07:29:56PM +0200, Sebastian Reichel wrote:
> [+cc Nicolas]
>
> Hello Mike,
>
> On Fri, Apr 12, 2024 at 08:53:58AM +0200, Mike Looijmans wrote:
> > > please share output of
> > > ./tools/testing/selftests/power_supply/test_power_supply_properties.sh
> > > below the fold with your next submission. It's useful for verifying,
> > > that you got the unit scaling correct for the standard properties :)
> >
> > Will do. Did a quick run on the driver as it is now, that yields the
> > following output:
> >
> > (Any thoughts on the "arithmetic syntax error" messages?)
>
> The script contains some bash specific shell extensions and should
> use /bin/bash instead of /bin/sh in the shebang. Just call it with
> /bin/bash ./tools/testing/... and you should get rid of them :)
>
> Nicolas, do you want to send a fix for that to Shuah with Reported-by
> from Mike?

It was easy to make it POSIX-compliant, so I sent a series doing that instead:

https://lore.kernel.org/all/20240415-supply-selftest-posix-sh-v1-0-328f008d698d@xxxxxxxxxxxxx

Thanks,
Nícolas