Re: [PATCH v2] pwm: dwc: allow suspend/resume for 16 channels

From: Uwe Kleine-König
Date: Mon Apr 15 2024 - 11:35:27 EST


Hello,

On Mon, Apr 15, 2024 at 01:10:51PM +0530, Raag Jadav wrote:
> With 16 channel pwm support, we're registering two instances of pwm_chip
> with 8 channels each. We need to update PM functions to use both instances
> of pwm_chip during power state transitions.
>
> Introduce struct dwc_pwm_drvdata and use it as driver_data, which will
> maintain both instances of pwm_chip along with dwc_pwm_info and allow us
> to use them inside suspend/resume handles.
>
> Fixes: ebf2c89eb95e ("pwm: dwc: Add 16 channel support for Intel Elkhart Lake")
> Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx>
> ---
> Changes since v1:
> - Drop error message for -ENOMEM
> - s/data/ddata/

Thanks for addressing these concerns. I applied this patch to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
now.

I consider sending this to Linus before v6.9, but I'd let it cook in
next a few days before doing so.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature