Re: [PATCH 5/6] [v3] kbuild: enable -Wcast-function-type-strict unconditionally

From: Kees Cook
Date: Mon Apr 15 2024 - 12:16:55 EST


On Mon, Apr 15, 2024 at 02:20:36PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> All known function cast warnings are now addressed, so the warning can
> be enabled globally to catch new ones more quickly.

Also yay! :)

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> scripts/Makefile.extrawarn | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 202e26e6f29f..1d13cecc7cc7 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -129,7 +129,6 @@ endif
> KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast)
> KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare
> KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access)
> -KBUILD_CFLAGS += $(call cc-disable-warning, cast-function-type-strict)
> KBUILD_CFLAGS += -Wno-enum-compare-conditional
> KBUILD_CFLAGS += -Wno-enum-enum-conversion
> endif
> --
> 2.39.2
>

--
Kees Cook