Re: [PATCH v3] ACPI: CPPC: Fix access width used for PCC registers

[Jarred White]

On 4/11/2024 4:18 PM, Vanshidhar Konda wrote:
> commit 2f4a4d63a193be6fd530d180bb13c3592052904c modified
> cpc_read/cpc_write to use access_width to read CPC registers. For PCC
> registers the access width field in the ACPI register macro specifies
> the PCC subspace id. For non-zero PCC subspace id the access width is
> incorrectly treated as access width. This causes errors when reading
> from PCC registers in the CPPC driver.
>
> For PCC registers base the size of read/write on the bit width field.
> The debug message in cpc_read/cpc_write is updated to print relevant
> information for the address space type used to read the register.
>
> Signed-off-by: Vanshidhar Konda <vanshikonda@xxxxxxxxxxxxxxxxxxxxxx>
> Tested-by: Jarred White <jarredwhite@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Jarred White <jarredwhite@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
> Cc: 5.15+ <stable@xxxxxxxxxxxxxxx> # 5.15+

Hi Vanshi,

v3 changes are good. Thanks again for catching this!


Thanks,
Jarred