Re: [PATCH net] net: bcmasp: fix memory leak when bringing down if

From: Justin Chen
Date: Mon Apr 15 2024 - 13:37:09 EST




On 4/14/24 4:23 AM, Markus Elfring wrote:
Can it be nicer to use the word “interface” instead of “if”
in the summary phrase?


"if" for interface is a term used in the network stack, but I can see why it is confusing. Can submit a v2.


When bringing down the TX rings we flush the rings but forget to
reclaimed the flushed packets. This lead to a memory leak since we
do not free the dma mapped buffers. …

I find this change description improvable.

* How do you think about to avoid typos?

* Would another imperative wording be more desirable?


The change description makes sense to me. Can you be a bit more specific as to what isn't clear here?

Thanks,
Justin

Regards,
Markus

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature