Re: [PATCH v2 2/2] mm/hugetlb: rename dissolve_free_huge_pages() to dissolve_free_hugetlb_folios()

[Sidhartha Kumar]

On 4/15/24 11:32 AM, Vishal Moola wrote:
> On Fri, Apr 12, 2024 at 11:21:39AM -0700, Sidhartha Kumar wrote:
> > dissolve_free_huge_pages() only uses folios internally, rename it to
> > dissolve_free_hugetlb_folios() and change the comments which reference it.
> >
> > Signed-off-by: Sidhartha Kumar <sidhartha.kumar@xxxxxxxxxx>
> > ---
> >   include/linux/hugetlb.h | 4 ++--
> >   mm/hugetlb.c            | 2 +-
> >   mm/memory_hotplug.c     | 4 ++--
> >   3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> > index f4191b10345d6..9ad7b97069cda 100644
> > --- a/include/linux/hugetlb.h
> > +++ b/include/linux/hugetlb.h
> > @@ -862,7 +862,7 @@ static inline int hstate_index(struct hstate *h)
> >   }
> >   
> >   extern int dissolve_free_hugetlb_folio(struct folio *folio);
> > -extern int dissolve_free_huge_pages(unsigned long start_pfn,
> > +extern int dissolve_free_hugetlb_folios(unsigned long start_pfn,
> >   				    unsigned long end_pfn);
>
> Same comment as the prior patch.
>
> Reviewed-by: Vishal Moola (Oracle) <vishal.moola@xxxxxxxxx>
Hi Andrew,

Could this diff also be folded in this patch to remove the extern per Vishal.

Thanks,
Sid

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index 9c96ef4d290a8..1bc93e7e315bb 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -862,7 +862,7 @@ static inline int hstate_index(struct hstate *h)
 }

 int dissolve_free_hugetlb_folio(struct folio *folio);
-extern int dissolve_free_hugetlb_folios(unsigned long start_pfn,
+int dissolve_free_hugetlb_folios(unsigned long start_pfn,
                                    unsigned long end_pfn);

 #ifdef CONFIG_MEMORY_FAILURE