Re: [PATCH v3 1/4] dt-bindings: input: Add Himax HX83102J touchscreen

From: Rob Herring
Date: Mon Apr 15 2024 - 23:31:16 EST



On Tue, 16 Apr 2024 10:12:25 +0800, Allen_Lin wrote:
> Add the HX83102j touchscreen device tree bindings documents.
> HX83102j is a Himax TDDI touchscreen controller.
> It's power sequence should be bound with a lcm driver, thus it
> needs to be a panel follower. Others are the same as normal SPI
> touchscreen controller.
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> Signed-off-by: Allen_Lin <allencl_lin@xxxxxxxxxxx>
> ---
> .../input/touchscreen/himax,hx83102j.yaml | 93 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml:93:7: [error] no new line character at the end of file (new-line-at-end-of-file)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/TY0PR06MB56112682F500F8761F76DBA99E082@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.