Re: [PATCH] drivers: scsi: fix shift-out-of-bounds in sg_build_indirect

[Sam Sun]

On Tue, Apr 16, 2024 at 1:26 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> On 4/14/24 20:14, Sam Sun wrote:
> > -    num = scatter_elem_sz;
> > +    num = max(scatter_elem_sz, PAGE_SIZE);
>
> Shouldn't the following statements be modified instead of the above
> statement? I think these are the only statements that can cause
> scatter_elem_sz to become smaller than PAGE_SIZE:
>
>         scatter_elem_sz = ret_sz;
>         scatter_elem_sz_prev = ret_sz;
>

Yes, these statements are the only statements that modify
scatter_elem_sz. However, ret_sz will never be less than PAGE_SIZE,
since it is calculated by 1 << (PAGE_SIZE + order), and order will not
be less than zero. So I think these statements do not need to be
modified.

scatter_elem_sz is also exported to userspace by sysfs interface
(macro module_param_named()), and privileged users could modify it to
any int they want. So I also set the exported type to uint in this
patch. Should I also change the type of scatter_elem_sz and
scatter_elem_sz_prev also to uint?

Best Regards,
Yue