Re: [EXTERNAL] Re: [PATCH v2 1/3] ALSA: hda/tas2781: Modification for add tas2781 driver for SPI

[Xu, Baojun]

Hi Andy,

Thansk for your suggestions, answer in line.
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: 09 April 2024 21:02
> To: Xu, Baojun
> Cc: tiwai@xxxxxxx; robh+dt@xxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; Lu, Kevin; Ding, Shenghao; Navada Kanyana, Mukund; alsa-devel@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxx; yung-chuan.liao@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxx; soyer@xxxxxx
> Subject: [EXTERNAL] Re: [PATCH v2 1/3] ALSA: hda/tas2781: Modification for add tas2781 driver for SPI
> 
> On Tue, Apr 09, 2024 at 10: 48: 13AM +0800, Baojun Xu wrote: > Integrate tas2781 configs for HP Laptops. Every tas2781 in the laptop > will work as a single speaker on SPI bus. The code support realtek as Realtek > the primary codec. 
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to phishing@xxxxxxxxxxx
> 
> ZjQcmQRYFpfptBannerEnd
> 
> On Tue, Apr 09, 2024 at 10:48:13AM +0800, Baojun Xu wrote:
> > Integrate tas2781 configs for HP Laptops. Every tas2781 in the laptop
> > will work as a single speaker on SPI bus. The code support realtek as
> 
> Realtek
> 
> > the primary codec.
> 
> ...
> 
> >               {"INT33FE", },
> >               {"INT3515", },
> >               /* Non-conforming _HID for Cirrus Logic already released */
> > +             {"TXNW2781", },
> 
> This seems wrong. The ID here is correct from ACPI specification perspective.
> Can you elaborate why you think it's "non-conforming _HID"?

Just put into middle of array, should no effective to functions.
Ok, I will change it's position in next patch.
> 
> >               {"CLSA0100", },
> >               {"CLSA0101", },
> > 
> > ...
> 
> >       /* Non-conforming _HID for Cirrus Logic already released */
> >       { "CLSA0100", (unsigned long)&cs35l41_hda },
> >       { "CLSA0101", (unsigned long)&cs35l41_hda },
> > +     { "TXNW2781", (unsigned long)&tas2781_hda },
> 
> Ditto.
> 
> >       { }
> 
> ...
> 
> > @@ -39,6 +39,7 @@ snd-hda-scodec-cs35l56-spi-objs :=  cs35l56_hda_spi.o
> >  snd-hda-cs-dsp-ctls-objs :=          hda_cs_dsp_ctl.o
> >  snd-hda-scodec-component-objs :=     hda_component.o
> >  snd-hda-scodec-tas2781-i2c-objs :=   tas2781_hda_i2c.o
> > +snd-hda-scodec-tas2781-spi-objs :=   tas2781_hda_spi.o tas2781_spi_fwlib.o
> 
> Actually these 'objs' has to be 'y', can you fix it in the prerequisite patch?
> 

Do you mean set CONFIG_SND_HDA_SCODEC_TAS2781_SPI=y in .config?
It's m now.

> Also wondering why fwlib is only a requirement for SPI. How does I²C work?

Because in I2C mode, one probed device driver will support all devices,
firmware binary is only one file, include all of devices.
But in SPI mode, multi driver probed, so we use single firmware binary for
every spi device.

> 
> --
> With Best Regards,
> Andy Shevchenko
> 
> 
> 

Best Regards
Jim