Re: [PATCH v3 2/2] arm64: dts: rockchip: Add Radxa ZERO 3W/3E

[Heiko Stübner]

Am Dienstag, 16. April 2024, 10:05:09 CEST schrieb Jonas Karlman:
> On 2024-04-15 17:03, Jonas Karlman wrote:
> > The Radxa ZERO 3W/3E is an ultra-small, high-performance single board
> > computer based on the Rockchip RK3566, with a compact form factor and
> > rich interfaces.
> > 
> > The ZERO 3W and ZERO 3E are basically the same size and model, but
> > differ only in storage and network interfaces.
> > 
> > - eMMC (3W)
> > - SD-card (both)
> > - Ethernet (3E)
> > - WiFi/BT (3W)
> > 
> > This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB.
> > 
> > Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx>
> > ---
> > v2: Add to Makefile
> > v3: Sort hdmi-con and leds nodes alphabetically
> > v3: Sort pmic@20 and regulator@40 nodes by reg
> > v3: Change to regulator-off-in-suspend for vdd_logic
> > 
> > Following issue is reported by dtbs_check and is fixed by patch at [1]:
> > 
> >   hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected)
> >   from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
> > 
> > [1] https://lore.kernel.org/linux-rockchip/3a035c16-75b5-471d-aa9d-e91c2bb9f8d0@xxxxxxxxx/
> > ---
> >  arch/arm64/boot/dts/rockchip/Makefile         |   2 +
> >  .../dts/rockchip/rk3566-radxa-zero-3e.dts     |  41 ++
> >  .../dts/rockchip/rk3566-radxa-zero-3w.dts     |  26 +
> >  .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++
> >  4 files changed, 512 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > 
> 
> [snip]
> 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > new file mode 100644
> > index 000000000000..ea8ade3a4c99
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> 
> [snip]
> 
> > +
> > +&i2c0 {
> > +	status = "okay";
> > +
> 
> [snip]
> 
> > +	vdd_cpu: regulator@40 {
> > +		compatible = "silergy,syr827";
> 
> After checking once more on schematic and inspecting the board this is
> actually a RK860-0 regulator and should use following:
> 
>   compatible = "rockchip,rk8600";
> 
> Will send a v4 with this change later this week.

ok, will wait for that then.

Heiko