Re: [PATCH v3 6/9] media: subdev: Add v4l2_subdev_is_streaming()

[Tomi Valkeinen]

On 12/04/2024 21:15, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Wed, Apr 10, 2024 at 03:35:53PM +0300, Tomi Valkeinen wrote:
> > Add a helper function which returns whether the subdevice is streaming,
> > i.e. if .s_stream or .enable_streams has been called successfully.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/media/v4l2-core/v4l2-subdev.c | 25 +++++++++++++++++++++++++
> >   include/media/v4l2-subdev.h           | 13 +++++++++++++
> >   2 files changed, 38 insertions(+)
> >
> > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> > index 3d2c9c224b8f..20b5a00cbeeb 100644
> > --- a/drivers/media/v4l2-core/v4l2-subdev.c
> > +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> > @@ -2419,6 +2419,31 @@ void v4l2_subdev_notify_event(struct v4l2_subdev *sd,
> >   }
> >   EXPORT_SYMBOL_GPL(v4l2_subdev_notify_event);
> >   
> > +bool v4l2_subdev_is_streaming(struct v4l2_subdev *sd)
> > +{
> > +	struct v4l2_subdev_state *state;
> > +
> > +	if (!v4l2_subdev_has_op(sd, pad, enable_streams))
> > +		return sd->streaming_enabled;
> > +
> > +	state = v4l2_subdev_get_locked_active_state(sd);
> > +
> > +	if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS))
> > +		return !!sd->enabled_pads;
>
> I think this can be moved above the
> v4l2_subdev_get_locked_active_state() call.

Yep. I think I originally thought that it'll be nice to get a warning 
here if the state is not locked, but perhaps that's pointless.

> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Any plan to convert drivers to this ?

No. Afaics, it will be per-driver manual work, no way to automate it.

 Tomi