Re: [PATCH] net: ipa: Remove unnecessary print function dev_err()

From: Simon Horman
Date: Tue Apr 16 2024 - 06:50:51 EST


On Mon, Apr 15, 2024 at 11:14:56AM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> ./drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8756
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

Hi Jiapeng Chong,

I don't think that you need to repost because of this,
but when sending Networking patches please specify the target tree
in the subject; net for fixes, and net-next for other patches.

e.g.

Subject: [PATCH net-next] ...

That notwithstanding, this patch looks good to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>