[PATCH 3/3] media: tuners: tuner_simple: fix error code handling in simple_tuner_attach()

From: Roman Smirnov
Date: Tue Apr 16 2024 - 07:46:30 EST


simple_tuner_attach() uses the hybrid_tuner_request_state() macro.
It may return the error code -ENOMEM, but the function handle
the value 0 instead.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: b9302fa7ed97 ("media: tuners: fix error return code of hybrid_tuner_request_state()")
Signed-off-by: Roman Smirnov <r.smirnov@xxxxxx>
---
drivers/media/tuners/tuner-simple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/tuners/tuner-simple.c b/drivers/media/tuners/tuner-simple.c
index 8fb186b25d6a..713ce2455910 100644
--- a/drivers/media/tuners/tuner-simple.c
+++ b/drivers/media/tuners/tuner-simple.c
@@ -1089,7 +1089,7 @@ struct dvb_frontend *simple_tuner_attach(struct dvb_frontend *fe,
i2c_adap, i2c_addr,
"tuner-simple");
switch (instance) {
- case 0:
+ case -ENOMEM:
mutex_unlock(&tuner_simple_list_mutex);
return NULL;
case 1:
--
2.34.1