Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup

From: Andi Shyti
Date: Tue Apr 16 2024 - 10:09:12 EST


On Tue, Apr 16, 2024 at 04:07:48PM +0200, Andi Shyti wrote:
> On Tue, Apr 16, 2024 at 03:59:13AM +0000, Chris Packham wrote:
> > On 16/04/24 08:54, Andi Shyti wrote:
> > >> /* Enable I2C interrupts for mpc5121 */
> > >> - node_ctrl = of_find_compatible_node(NULL, NULL,
> > >> - "fsl,mpc5121-i2c-ctrl");
> > >> + struct device_node *node_ctrl __free(device_node) =
> > > How have you tested this?
> >
> > I'm not sure I know anyone that still has a mpc5121. Maybe someone on
> > linuxppc-dev?
>
> that's why I was asking, this would be the first driver in i2c
> using Rob's __free(device_node).

Jonathan's, of course :-)

Andi