RE: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC

[Paller, Kim Seer]

> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Saturday, April 13, 2024 11:27 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Lars-Peter Clausen <lars@xxxxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Liam Girdwood
> <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; David Lechner
> <dlechner@xxxxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>
> Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
> 
> [External]
> 
> On Fri, 12 Apr 2024 11:21:01 +0800
> Kim Seer Paller <kimseer.paller@xxxxxxxxxx> wrote:
> 
> > Define the sysfs interface for toggle capable channels.
> >
> > Toggle enabled channels will have:
> >
> >  * out_currentY_toggle_en
> >  * out_currentY_raw0
> >  * out_currentY_raw1
> >  * out_currentY_symbol
> >
> > The common interface present in all channels is:
> >
> >  * out_currentY_raw (not present in toggle enabled channels)
> >  * out_currentY_raw_available
> >  * out_currentY_powerdown
> >  * out_currentY_scale
> >  * out_currentY_offset
> >
> > Co-developed-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > ---
> >  .../ABI/testing/sysfs-bus-iio-dac-ltc2672     | 30 +++++++++++++++++++
> 
> You can only have per device ABI defined if that is the only user
> of the ABI.  That may actually be true here but given I've asked you to
> generalize
> the voltage equivalent, I think we've shown this is general enough that the
> current
> version should also be raised to sysfs-bus-iio-dac

I'm still getting familiar with ABI documentation. If I understand correctly,
generalizing the documentation to cover both parts would also mean we remove
the overlapping sections from the ltc2688 ABI. Is that the correct approach?