Re: [PATCH v1] arm64: dts: qcom: sc7280: Remove CTS/RTS configuration

[Konrad Dybcio]

On 4/16/24 13:38, Luca Weiss wrote:
> On Tue Apr 16, 2024 at 12:56 PM CEST, Viken Dadhaniya wrote:
> > Remove CTS and RTS pinctrl configuration for UART5 node as
> > it's designed for debug UART for all the board variants of the
> > sc7280 chipset.
> >
> > Also change compatible string to debug UART.
>
> This change has little to do with the SoC design though and is dependent
> on the usage on a given board, right? Also the QCM6490 datasheet
> mentions gpio21 & gpio22 can be used for UART_CTS and UART_RFR.

Yeah, using it as a debug uart doesn't rule out flow control I don't think

> But at least consistency-wise this change makes sense, in practically
> all other SoCs one UART is marked as geni-debug-uart.
>
> But with this patch you should then also remove some overrides that are
> placed in various boards already?
>
> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts:     compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts:       compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts:   compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:       compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi:     compatible = "qcom,geni-debug-uart";

Definitely

Konrad