Re: [PATCH V4 0/4] KVM: x86: Make bus clock frequency for vAPIC timer configurable

From: Edgecombe, Rick P
Date: Tue Apr 16 2024 - 13:09:58 EST


On Thu, 2024-03-21 at 09:37 -0700, Reinette Chatre wrote:
>
> Summary
> -------
> Add KVM_CAP_X86_APIC_BUS_FREQUENCY capability to configure the APIC
> bus clock frequency for APIC timer emulation.
> Allow KVM_ENABLE_CAPABILITY(KVM_CAP_X86_APIC_BUS_FREQUENCY) to set the
> frequency in nanoseconds. When using this capability, the user space
> VMM should configure CPUID leaf 0x15 to advertise the frequency.

Looks good to me and...
Tested-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>

The only thing missing is actually integrating it into TDX qemu patches and
testing the resulting TD. I think we are making a fair assumption that the
problem should be resolved based on the analysis, but we have not actually
tested that part. Is that right? What do you think?