Re: [PATCH 1/3] hwmon: Add thermal sensor driver for Surface Aggregator Module

[Maximilian Luz]

On 4/16/24 3:27 PM, Guenter Roeck wrote:
> On Sat, Mar 30, 2024 at 12:24:00PM +0100, Maximilian Luz wrote:
> > Some of the newer Microsoft Surface devices (such as the Surface Book
> > 3 and Pro 9) have thermal sensors connected via the Surface Aggregator
> > Module (the embedded controller on those devices). Add a basic driver
> > to read out the temperature values of those sensors.
> >
> > Link: https://github.com/linux-surface/surface-aggregator-module/issues/59
> > Signed-off-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > ---
> [ ... ]
> > +	hwmon_dev = devm_hwmon_device_register_with_info(&sdev->dev,
> > +			"surface_thermal", ssam_temp, &ssam_temp_hwmon_chip_info,
> > +			NULL);
> > +	if (IS_ERR(hwmon_dev))
> > +		return PTR_ERR(hwmon_dev);
> > +
> > +	return 0;
>
> 	return PTR_ERR_OR_ZERO(hwmon_dev);

ACK. Will fix this and the blank lines.

Thanks,
Max