Re: linux-next: build warning after merge of the mm-hotfixes tree

From: Andrew Morton
Date: Tue Apr 16 2024 - 14:54:05 EST


On Tue, 16 Apr 2024 17:35:25 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> Hi all,
>
> After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
> produced this warning:
>
> lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
> lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead
>
> Introduced by commit
>
> aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
>
> from the mm-hotfixes-unstable branch of the mm-hotfixes tree.

Thanks. How's this?

--- a/lib/bootconfig.c~bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy-fix
+++ a/lib/bootconfig.c
@@ -901,7 +901,8 @@ static int __init xbc_parse_tree(void)
}

/**
- * xbc_exit() - Clean up all parsed bootconfig
+ * _xbc_exit() - Clean up all parsed bootconfig
+ * @early: in early xbc init error
*
* This clears all data structures of parsed bootconfig on memory.
* If you need to reuse xbc_init() with new boot config, you can
_