Re: [PATCH v8 1/3] PNP: Add dev_is_pnp() macro

[Rafael J. Wysocki]

On Tue, Apr 16, 2024 at 5:16 AM Guanbing Huang <albanhuang0@xxxxxxxxx> wrote:
>
> From: Guanbing Huang <albanhuang@xxxxxxxxxxx>
>
> Add dev_is_pnp() macro to determine whether the device is a PNP device.
>
> Signed-off-by: Guanbing Huang <albanhuang@xxxxxxxxxxx>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Reviewed-by: Bing Fan <tombinfan@xxxxxxxxxxx>
> Tested-by: Linheng Du <dylanlhdu@xxxxxxxxxxx>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

and please feel free to route it along with the rest of the series.

Thanks!

> ---
> v7 -> v8: delete a "Reviewed-by" tag, delete a "Reported-by" tag
> v6 -> v7: add a "Reviewed-by" tag and a "Reported-by" tag, fix build errors when CONFIG_PNP is not enabled
> v5 -> v6: fix the issue that the cover letter is not chained with the patch series
> v4 -> v5: change "pnp" in the commit message to uppercase
>
>  include/linux/pnp.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index ddbe7c3ca4ce..82561242cda4 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -469,6 +469,8 @@ int compare_pnp_id(struct pnp_id *pos, const char *id);
>  int pnp_register_driver(struct pnp_driver *drv);
>  void pnp_unregister_driver(struct pnp_driver *drv);
>
> +#define dev_is_pnp(d) ((d)->bus == &pnp_bus_type)
> +
>  #else
>
>  /* device management */
> @@ -500,6 +502,8 @@ static inline int compare_pnp_id(struct pnp_id *pos, const char *id) { return -E
>  static inline int pnp_register_driver(struct pnp_driver *drv) { return -ENODEV; }
>  static inline void pnp_unregister_driver(struct pnp_driver *drv) { }
>
> +#define dev_is_pnp(d) false
> +
>  #endif /* CONFIG_PNP */
>
>  /**
> --