Re: [PATCH 1/4] scsi: ufs: core: Make use of guard(spinlock_irqsave)

[Bart Van Assche]

On 4/16/24 03:23, Avri Altman wrote:
> +#define SERIALIZE_HOST_IRQSAVE(hba) guard(spinlock_irqsave)(hba->host->host_lock)

Something I have brought up before: what does the host lock protect in
the UFS driver? Rather than reworking the code that acquires and
releases the host lock, all uses of the host lock should be eliminated
from the UFS driver. The host lock should be replaced with new locks of
which it is clearly documented what member variables these new locks
protect.

Thanks,

Bart.