[PATCH] [PATCH] staging: fbtft Removed redundant parentheses on logical expr

From: Ashok Kumar
Date: Tue Apr 16 2024 - 12:19:32 EST

Next message: Peter Zijlstra: "Re: [PATCH v4 00/30] NT synchronization primitive driver"
Previous message: Dave Martin: "Re: [PATCH v1 08/31] x86/resctrl: Move resctrl types to a separate header"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Adhere to Linux Kernel coding style removed redundant parentheses,
multiple blank lines and indentation alignment.

Reported by checkpatch.pl

------
fb_ili9320.c

+ if ((devcode !=3D 0x0000) && (devcode !=3D 0x9320))

------
fb_ra8875.c

CHECK: Unnecessary parentheses around 'par->info->var.xres =3D=3D 320'
+ if ((par->info->var.xres =3D=3D 320) && (par->info->var.yres =3D=3D
240)) {

------
fb_ssd1325.c

CHECK: Please don't use multiple blank lines
------

fb_tinylcd.c - indentation adjustment

-----
fbtft-bus.c

CHECK: Unnecessary parentheses around 'par->spi->bits_per_word =3D=3D 8'

------
fbtft-core.c

CHECK: Please don't use multiple blank lines

CHECK: Unnecessary parentheses around '!txbuflen'

CHECK: Please don't use multiple blank lines
------

Signed-off-by: Ashok Kumar <ashokemailat@xxxxxxxxx>
---
drivers/staging/fbtft/fb_ili9320.c | 2 +-
drivers/staging/fbtft/fb_ra8875.c | 8 ++++----
drivers/staging/fbtft/fb_ssd1325.c | 2 --
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
drivers/staging/fbtft/fbtft-bus.c | 6 +++---
drivers/staging/fbtft/fbtft-core.c | 7 +------
6 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/fbtft/fb_ili9320.c
b/drivers/staging/fbtft/fb_ili9320.c
index 0be7c2d51548..409b54cc562e 100644
--- a/drivers/staging/fbtft/fb_ili9320.c
+++ b/drivers/staging/fbtft/fb_ili9320.c
@@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
devcode =3D read_devicecode(par);
fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code:
0x%04X\n",
devcode);
- if ((devcode !=3D 0x0000) && (devcode !=3D 0x9320))
+ if (devcode !=3D 0x0000 && devcode !=3D 0x9320)
dev_warn(par->info->device,
"Unrecognized Device code: 0x%04X (expected
0x9320)\n",
devcode);
diff --git a/drivers/staging/fbtft/fb_ra8875.c
b/drivers/staging/fbtft/fb_ra8875.c
index 398bdbf53c9a..4b79fb48c5f0 100644
--- a/drivers/staging/fbtft/fb_ra8875.c
+++ b/drivers/staging/fbtft/fb_ra8875.c
@@ -50,7 +50,7 @@ static int init_display(struct fbtft_par *par)
=20
par->fbtftops.reset(par);
=20
- if ((par->info->var.xres =3D=3D 320) && (par->info->var.yres =3D=3D
240)) {
+ if (par->info->var.xres =3D=3D 320 && par->info->var.yres =3D=3D 240)
{
/* PLL clock frequency */
write_reg(par, 0x88, 0x0A);
write_reg(par, 0x89, 0x02);
@@ -74,8 +74,8 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x1D, 0x0E);
write_reg(par, 0x1E, 0x00);
write_reg(par, 0x1F, 0x02);
- } else if ((par->info->var.xres =3D=3D 480) &&
- (par->info->var.yres =3D=3D 272)) {
+ } else if (par->info->var.xres =3D=3D 480 &&
+ par->info->var.yres =3D=3D 272) {
/* PLL clock frequency */
write_reg(par, 0x88, 0x0A);
write_reg(par, 0x89, 0x02);
@@ -111,7 +111,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x04, 0x01);
mdelay(1);
/* horizontal settings */
- write_reg(par, 0x14, 0x4F);
+write_reg(par, 0x14, 0x4F);
write_reg(par, 0x15, 0x05);
write_reg(par, 0x16, 0x0F);
write_reg(par, 0x17, 0x01);
diff --git a/drivers/staging/fbtft/fb_ssd1325.c
b/drivers/staging/fbtft/fb_ssd1325.c
index 796a2ac3e194..69aa808c7e23 100644
--- a/drivers/staging/fbtft/fb_ssd1325.c
+++ b/drivers/staging/fbtft/fb_ssd1325.c
@@ -109,8 +109,6 @@ static int set_gamma(struct fbtft_par *par, u32
*curves)
{
int i;
=20
- fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
-
for (i =3D 0; i < GAMMA_LEN; i++) {
if (i > 0 && curves[i] < 1) {
dev_err(par->info->device,
diff --git a/drivers/staging/fbtft/fb_tinylcd.c
b/drivers/staging/fbtft/fb_tinylcd.c
index 9469248f2c50..60cda57bcb33 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xE5, 0x00);
write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
- 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+ 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
udelay(250);
diff --git a/drivers/staging/fbtft/fbtft-bus.c
b/drivers/staging/fbtft/fbtft-bus.c
index 3d422bc11641..02d7dbd38678 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@
out: \
} =20
\
EXPORT_SYMBOL(func);
=20
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16,
cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
=20
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
@@ -85,7 +85,7 @@ void fbtft_write_reg8_bus9(struct fbtft_par *par, int
len, ...)
if (len <=3D 0)
return;
=20
- if (par->spi && (par->spi->bits_per_word =3D=3D 8)) {
+ if (par->spi && par->spi->bits_per_word =3D=3D 8) {
/* we're emulating 9-bit, pad start of buffer with no-
ops
* (assuming here that zero is a no-op)
*/
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 38845f23023f..98ffca49df81 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -216,8 +216,6 @@ static void fbtft_reset(struct fbtft_par *par)
if (!par->gpio.reset)
return;
=20
- fbtft_par_dbg(DEBUG_RESET, par, "%s()\n", __func__);
-
gpiod_set_value_cansleep(par->gpio.reset, 1);
usleep_range(20, 40);
gpiod_set_value_cansleep(par->gpio.reset, 0);
@@ -667,7 +665,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct
fbtft_display *display,
txbuflen =3D 0;
=20
#ifdef __LITTLE_ENDIAN
- if ((!txbuflen) && (bpp > 8))
+ if (!txbuflen && bpp > 8)
txbuflen =3D PAGE_SIZE; /* need buffer for byteswapping
*/
#endif
=20
@@ -1053,8 +1051,6 @@ static int fbtft_verify_gpios(struct fbtft_par
*par)
struct fbtft_platform_data *pdata =3D par->pdata;
int i;
=20
- fbtft_par_dbg(DEBUG_VERIFY_GPIOS, par, "%s()\n", __func__);
-
if (pdata->display.buswidth !=3D 9 && par->startbyte =3D=3D 0 &&
!par->gpio.dc) {
dev_err(par->info->device,
@@ -1159,7 +1155,6 @@ int fbtft_probe_common(struct fbtft_display
*display,
dev =3D &pdev->dev;
=20
if (unlikely(display->debug & DEBUG_DRIVER_INIT_FUNCTIONS))
- dev_info(dev, "%s()\n", __func__);
=20
pdata =3D dev->platform_data;
if (!pdata) {
--=20
2.34.1

Next message: Peter Zijlstra: "Re: [PATCH v4 00/30] NT synchronization primitive driver"
Previous message: Dave Martin: "Re: [PATCH v1 08/31] x86/resctrl: Move resctrl types to a separate header"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]