Re: [PATCH 2/4] hwmon: (max6639) : Utilise pwm subsystem

From: Guenter Roeck
Date: Tue Apr 16 2024 - 17:29:41 EST


On Tue, Apr 16, 2024 at 10:47:15PM +0530, Naresh Solanki wrote:
> Utilise pwm subsystem for fan pwm handling
>
> Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>

That adds a lot of complexity to the driver. I am missing the benefits.
You are supposed to explain why you are making changes, not just that
you are making them.

Why are you making those changes ?

Guenter