RE: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal base instead of hex
From: Brelinski, Tony
Date: Tue Apr 16 2024 - 19:13:37 EST
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Erwan Velu
> Sent: Tuesday, March 19, 2024 7:17 AM
> Cc: Velu, Erwan <e.velu@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Eric
> Dumazet <edumazet@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; Nguyen,
> Anthony L <anthony.l.nguyen@xxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; David
> S. Miller <davem@xxxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal base
> instead of hex
>
> If the MFS is set below the default (0x2600), a warning message is reported
> like the following :
>
> MFS for port 1 has been set below the default: 600
>
> This message is a bit confusing as the number shown here (600) is in fact an
> hexa number: 0x600 = 1536
>
> Without any explicit "0x" prefix, this message is read like the MFS is set to 600
> bytes.
>
> MFS, as per MTUs, are usually expressed in decimal base.
>
> This commit reports both current and default MFS values in decimal so it's less
> confusing for end-users.
>
> A typical warning message looks like the following :
>
> MFS for port 1 (1536) has been set below the default (9728)
>
> Signed-off-by: Erwan Velu <e.velu@xxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Tony Brelinski <tony.brelinski@xxxxxxxxx>