Re: [PATCH net-next v8 10/17] net: pse-pd: Add support for PSE PIs

[Jakub Kicinski]

On Sun, 14 Apr 2024 16:21:59 +0200 Kory Maincent wrote:
> +/**
> + * of_pse_match_pi - Return the PSE PI id of the device node phandle
> + * @pcdev: a pointer to the PSE controller device
> + * @np: a pointer to the device node
> + */
> +static int of_pse_match_pi(struct pse_controller_dev *pcdev,

There's new nitpick from kernel-doc - if the function returns something
the kdoc needs to document Return:  ..

Sorry I missed this check failing because the fact that the series is
17 patches lights it up as red in patchwork :( I'll apply the first
3 patches to make v9 smaller.

> +			   struct device_node *np)
> +{
> +	int i;
> +
> +	for (i = 0; i <= pcdev->nr_lines; i++) {
> +		if (pcdev->pi[i].np == np)
> +			return i;
> +	}
> +
> +	return -EINVAL;
> +}
> +
> +/**
> + * psec_id_xlate - translate pse_spec to the PSE line number according
> + *		   to the number of pse-cells in case of no pse_pi node
> + * @pcdev: a pointer to the PSE controller device
> + * @pse_spec: PSE line specifier as found in the device tree
> + *
> + * Return 0 if #pse-cells = <0>. Return PSE line number otherwise.

here missing ":"

> + */
> +static int psec_id_xlate(struct pse_controller_dev *pcdev,
> +			 const struct of_phandle_args *pse_spec)