Re: [PATCH net-next v8 06/17] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface

[Jakub Kicinski]

On Sun, 14 Apr 2024 16:21:55 +0200 Kory Maincent wrote:
> +	    !(pse_has_podl(phydev->psec))) {
> +		NL_SET_ERR_MSG_ATTR(info->extack,
> +				    tb[ETHTOOL_A_PODL_PSE_ADMIN_CONTROL],
> +				    "setting PoDL PSE admin control not supported");
> +		return -EOPNOTSUPP;
> +	}
> +	if (tb[ETHTOOL_A_C33_PSE_ADMIN_CONTROL] &&
> +	    !(pse_has_c33(phydev->psec))) {

nit: unnecessary parenthesis around the function call