Re: [PATCH] memblock: add no-map alloc functions

[Wei Yang]

On Mon, Apr 15, 2024 at 06:26:55PM +0300, Mike Rapoport wrote:
[...]
>> +	
>
>This changes behaviour of internal function, what effect will it have on
>the users?
>
>>  	if (!base)
>>  		return -ENOMEM;
>>  
>>  	*res_base = base;
>>  	if (nomap) {
>>  		err = memblock_mark_nomap(base, size);

Mike

One question may not directly relevant to this thread.

NOMAP doesn't apply to all arch? I took a look into the direct mapping
function on x86, memory_map_top_down(). It seems iterate all available pfn
instead of skipping NOMAP range. 

>> -		if (err)
>> -			memblock_phys_free(base, size);
>>  	}
>>  
>>  	kmemleak_ignore_phys(base);
>
>-- 
>Sincerely yours,
>Mike.

-- 
Wei Yang
Help you, Help me