Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review easier

From: Alexander Graf
Date: Wed Apr 17 2024 - 05:13:11 EST



On 17.04.24 11:05, Babis Chalios wrote:


On 17/4/24 10:35, Alexander Graf wrote:

On 17.04.24 10:12, Babis Chalios wrote:
From: Sudan Landge <sudanl@xxxxxxxxxx>

Rearrage the functions of vmgenid to make the next commit,
which re-implements vmgenid as a platform driver, easier to review.

Signed-off-by: Sudan Landge <sudanl@xxxxxxxxxx>


You can't sign off on behalf of someone else. The SoB here needs to be yours. If you are taking over this code from Sudan, I'd suggest to take over full ownership of it and put your own name as author and SoB in all patches.


I thought about it and it seemed weird to me that I take over SoB and authorship since I only touched one line in one of
the patches, but I will be taking over the patches, so I can do that if that's the way we things are done.

Does it make sense to at least add "Co-authored-by Sudan Landge <sudanl@xxxxxxxxxx>" here?


You can certainly do that, yes.


Alex





Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879