Re: [PATCH 1/2] dt-bindings: net/nfc: ti,trf7970a: Add rx-gain-reduction option

From: Krzysztof Kozlowski
Date: Wed Apr 17 2024 - 09:13:00 EST


On 17/04/2024 00:18, Paul Geurts wrote:
> Add option to reduce the RX antenna gain to be able to reduce the
> sensitivity.
>
> Signed-off-by: Paul Geurts <paul_geurts@xxxxxxx>
> ---
> Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> index d0332eb76ad2..bbd045f6cf04 100644
> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> @@ -55,6 +55,11 @@ properties:
> description: |
> Regulator for supply voltage to VIN pin
>
> + rx-gain-reduction:

Missing vendor prefix.

> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |

Do not need '|' unless you need to preserve formatting.

> + Specify a RX gain reduction to reduce antenna sensitivity.

Reduction by what? What are the units?


Best regards,
Krzysztof