Re: [net-next PATCH 2/9] octeontx2-pf: RVU representor driver
From: kernel test robot
Date: Wed Apr 17 2024 - 12:23:40 EST
Hi Geetha,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Geetha-sowjanya/octeontx2-pf-Refactoring-RVU-driver/20240416-131052
base: net-next/main
patch link: https://lore.kernel.org/r/20240416050616.6056-3-gakula%40marvell.com
patch subject: [net-next PATCH 2/9] octeontx2-pf: RVU representor driver
config: loongarch-randconfig-r064-20240417 (https://download.01.org/0day-ci/archive/20240418/202404180051.sgxiT7pZ-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180051.sgxiT7pZ-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404180051.sgxiT7pZ-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_tx_napi_handler':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:470:28: error: 'struct otx2_nic' has no member named 'reps'
470 | ndev = pfvf->reps[qidx]->netdev;
| ^~
vim +470 drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
449
450 static int otx2_tx_napi_handler(struct otx2_nic *pfvf,
451 struct otx2_cq_queue *cq, int budget)
452 {
453 int tx_pkts = 0, tx_bytes = 0, qidx;
454 struct otx2_snd_queue *sq;
455 struct nix_cqe_tx_s *cqe;
456 struct net_device *ndev;
457 int processed_cqe = 0;
458
459 if (cq->pend_cqe >= budget)
460 goto process_cqe;
461
462 if (otx2_nix_cq_op_status(pfvf, cq) || !cq->pend_cqe)
463 return 0;
464
465 process_cqe:
466 qidx = cq->cq_idx - pfvf->hw.rx_queues;
467 sq = &pfvf->qset.sq[qidx];
468
469 if (pfvf->flags & OTX2_FLAG_REP_MODE_ENABLED)
> 470 ndev = pfvf->reps[qidx]->netdev;
471 else
472 ndev = pfvf->netdev;
473
474 while (likely(processed_cqe < budget) && cq->pend_cqe) {
475 cqe = (struct nix_cqe_tx_s *)otx2_get_next_cqe(cq);
476 if (unlikely(!cqe)) {
477 if (!processed_cqe)
478 return 0;
479 break;
480 }
481
482 qidx = cq->cq_idx - pfvf->hw.rx_queues;
483
484 if (cq->cq_type == CQ_XDP)
485 otx2_xdp_snd_pkt_handler(pfvf, sq, cqe);
486 else
487 otx2_snd_pkt_handler(pfvf, ndev, cq, &pfvf->qset.sq[qidx],
488 cqe, budget, &tx_pkts, &tx_bytes);
489
490 cqe->hdr.cqe_type = NIX_XQE_TYPE_INVALID;
491 processed_cqe++;
492 cq->pend_cqe--;
493
494 sq->cons_head++;
495 sq->cons_head &= (sq->sqe_cnt - 1);
496 }
497
498 /* Free CQEs to HW */
499 otx2_write64(pfvf, NIX_LF_CQ_OP_DOOR,
500 ((u64)cq->cq_idx << 32) | processed_cqe);
501
502 if (likely(tx_pkts)) {
503 struct netdev_queue *txq;
504
505 qidx = cq->cq_idx - pfvf->hw.rx_queues;
506
507 if (qidx >= pfvf->hw.tx_queues)
508 qidx -= pfvf->hw.xdp_queues;
509
510 if (pfvf->flags & OTX2_FLAG_REP_MODE_ENABLED)
511 qidx = 0;
512 txq = netdev_get_tx_queue(pfvf->netdev, qidx);
513 netdev_tx_completed_queue(txq, tx_pkts, tx_bytes);
514 /* Check if queue was stopped earlier due to ring full */
515 smp_mb();
516 if (netif_tx_queue_stopped(txq) &&
517 netif_carrier_ok(ndev))
518 netif_tx_wake_queue(txq);
519 }
520 return 0;
521 }
522
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki