Re: [PATCH v3 0/2] Add a driver for Epson RX8111 RTC

[Alexandre Belloni]

On Mon, 20 Nov 2023 15:49:25 +0100, Waqar Hameed wrote:
> In this patch series we add a basic driver for Epson RX8111 RTC with
> support for only reading/writing the time and the `ioctl`s `RTC_VL_READ`
> and `RTC_VL_CLR`.
> 
> Datasheet: https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
> 
> Changes in v3:
> * Remove macro define `RX8111_DRV_NAME` for the driver name.
> * Remove macro function `RX8111_TIME_BUF_IDX` and instead use the
>   offsets as indices directly.
> * Remove `rx8111_setup()` that disabled extended functionality and
>   interrupts.
> * Remove comments explaining register value conversions in
>   `rx8111_read/set_time()`.
> * Check/clear register flag XST (oscillation stoppage) in
>   `rx8111_read/set_time()`.
> * Change `vlval` to `unsigned int` in `rx8111_ioctl()`.
> * Remove `case RTC_VL_CLR` in `rx8111_ioctl()`.
> * Convert all `dev_err()` to `dev_dbg()`.
> * Convert all `dev_err_probe()` to `dev_dbg()` in probe.
> * Return without printing from `devm_rtc_register_device()` in probe.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: rtc: Add Epson RX8111
      https://git.kernel.org/abelloni/c/c6a2fb6d14bf
[2/2] rtc: Add driver for Epson RX8111
      https://git.kernel.org/abelloni/c/f8c81d15f4bb

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com