Re: [PATCH v3 1/2] arm64: dts: qcom: qcm6490-idp: Enable various remoteprocs

[Dmitry Baryshkov]

On Wed, 17 Apr 2024 at 15:11, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
>
> Enable the ADSP, CDSP, MPSS and WPSS that are found on the SoC.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index f8f8a43f638d..01ea64b16969 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -580,6 +580,26 @@ &qupv3_id_0 {
>         status = "okay";
>  };
>
> +&remoteproc_adsp {
> +       firmware-name = "qcom/qcm6490/adsp.mbn";

Is there a difference between qcm6490 and qcs6490 firmware files? If
there is none, can we use the existing paths?

I assume that modem is the only difference there. In such a case,
please use "modem_nm.mbn" for the not-modem mpss and plain "modem.mbn"
for the standard one.

> +       status = "okay";
> +};
> +
> +&remoteproc_cdsp {
> +       firmware-name = "qcom/qcm6490/cdsp.mbn";
> +       status = "okay";
> +};
> +
> +&remoteproc_mpss {
> +       firmware-name = "qcom/qcm6490/modem.mbn";
> +       status = "okay";
> +};
> +
> +&remoteproc_wpss {
> +       firmware-name = "qcom/qcm6490/wpss.mbn";
> +       status = "okay";
> +};
> +
>  &sdhc_1 {
>         non-removable;
>         no-sd;
> --
> 2.42.0
>
>


-- 
With best wishes
Dmitry