Re: [PATCH] kbuild: buildtar: add comments about inconsistent package generation

[Nicolas Schier]

On Tue 16 Apr 2024 11:07:48 GMT, Masahiro Yamada wrote:
> On Mon, Apr 15, 2024 at 2:42 AM Masahiro Yamada 
> <masahiroy@xxxxxxxxxx> wrote:
> >
> > scripts/package/buildtar checks some kernel packages, and copies the
> > first image found. This may potentially produce an inconsistent (and
> > possibly wrong) package.
> >
> > For instance, the for-loop for arm64 checks Image.{bz2,gz,lz4,lzma,lzo},
> > and vmlinuz.efi, then copies the first image found, which might be a
> > stale image.
> >
> > When CONFIG_EFI_ZBOOT is enabled in the pristine source tree,
> > 'make ARCH=arm64 tar-pkg' will build and copy vmlinuz.efi. This is the
> > expected behavior.
> >
> > If you build the kernel with CONFIG_EFI_ZBOOT, Image.gz will be created,
> 
> 
> The correct sentence is
> 
> If you build the kernel with CONFIG_EFI_ZBOOT disabled, ...

Thanks, I appreciate the detailed descriptions and comments. 

Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>

Kind regards,
Nicolas

Attachment: signature.asc
Description: PGP signature