Re: [PATCH 5/7] KVM: x86/mmu: Introduce kvm_tdp_map_page() to populate guest memory

From: Sean Christopherson
Date: Wed Apr 17 2024 - 17:34:53 EST


On Wed, Apr 17, 2024, Sean Christopherson wrote:
> On Wed, Apr 17, 2024, Paolo Bonzini wrote:
> > + case RET_PF_EMULATE:
> > + return -EINVAL;

Almost forgot. EINVAL on emulation is weird. I don't know that any return code
is going to be "good", but I think just about anything is better than EINVAL,
e.g. arguably this could be -EBUSY since retrying after creating a memslot would
succeed.