RE: [PATCH v4 1/2] dmaengine: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
From: Joy Zou
Date: Wed Apr 17 2024 - 21:38:31 EST
> -----Original Message-----
> From: Frank Li <frank.li@xxxxxxx>
> Sent: 2024年4月17日 22:40
> To: Joy Zou <joy.zou@xxxxxxx>
> Cc: Peng Fan <peng.fan@xxxxxxx>; vkoul@xxxxxxxxxx; robh@xxxxxxxxxx;
> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> dmaengine@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 1/2] dmaengine: fsl-edma: clean up unused
> "fsl,imx8qm-adma" compatible string
> > diff --git a/drivers/dma/fsl-edma-common.c
> > b/drivers/dma/fsl-edma-common.c index f9144b015439..ed93e01282d5
> > 100644
> > --- a/drivers/dma/fsl-edma-common.c
> > +++ b/drivers/dma/fsl-edma-common.c
> > @@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct
> > fsl_edma_chan *fsl_chan)
> >
> > flags = fsl_edma_drvflags(fsl_chan);
> > val = edma_readl_chreg(fsl_chan, ch_sbr);
> > - /* Remote/local swapped wrongly on iMX8 QM Audio edma */
> > - if (flags & FSL_EDMA_DRV_QUIRK_SWAPPED) {
>
> You forget remove FSL_EDMA_DRV_QUIRK_SWAPPED in fsl-edma-common.h
Thanks your comments!
Yeah, will remove it in next version.
BR
Joy Zou
>
> Frank
>