Re: [PATCH v19 079/130] KVM: TDX: vcpu_run: save/restore host state(host kernel gs)

[Binbin Wu]

On 4/13/2024 4:17 AM, Isaku Yamahata wrote:
> > > +void tdx_prepare_switch_to_guest(struct kvm_vcpu *vcpu)
> > Just like vmx_prepare_switch_to_host(), the input can be "struct vcpu_tdx
> > *", since vcpu is not used inside the function.
> > And the callsites just use "to_tdx(vcpu)"
> >
> > > +{
> > > +	struct vcpu_tdx *tdx = to_tdx(vcpu);
> > Then, this can be dropped.
> prepare_switch_to_guest() is used for kvm_x86_ops.prepare_switch_to_guest().
> kvm_x86_ops consistently takes struct kvm_vcpu.

Oh yes, it's not suitable for tdx_prepare_switch_to_guest().
Still, it can be for tdx_prepare_switch_to_host().